Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed memory bug in storage maps #684

Merged
merged 1 commit into from
Mar 8, 2022
Merged

fixed memory bug in storage maps #684

merged 1 commit into from
Mar 8, 2022

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Mar 4, 2022 •
edited
Loading

What was wrong?

The region of memory used to compute the slot of a storage map value was not being allocated.

How was it fixed?

⌨️

To-Do

  • OPTIONAL: Update Spec if applicable
  • Add entry to the release notes (may forgo for trivial changes)
  • Clean up commit history

@g-r-a-n-t g-r-a-n-t requested review from sbillig and Y-Nak March 4, 2022 17:59
Y-Nak
Y-Nak approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@Y-Nak Y-Nak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question. When is memory used before initialization in current yulgen?
Oh, an array is the one example I guess.

@g-r-a-n-t g-r-a-n-t merged commit d92cd20 into ethereum:master Mar 8, 2022
@g-r-a-n-t g-r-a-n-t mentioned this pull request Jun 2, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y-Nak Y-Nak Y-Nak approved these changes

@sbillig sbillig Awaiting requested review from sbillig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-r-a-n-t @Y-Nak