Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abi specs #688

Closed
wants to merge 4 commits into from
Closed

Abi specs #688

wants to merge 4 commits into from

Conversation

g-r-a-n-t
Copy link
Member

What was wrong?

How was it fixed?

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@g-r-a-n-t g-r-a-n-t marked this pull request as draft March 12, 2022 18:32
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2022

Codecov Report

Merging #688 (8dcf631) into master (2097ec5) will decrease coverage by 0.00%.
The diff coverage is 84.90%.

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   82.12%   82.11%   -0.01%     
==========================================
  Files         125      125              
  Lines       10849    10888      +39     
==========================================
+ Hits         8910     8941      +31     
- Misses       1939     1947       +8     
Impacted Files Coverage Δ
crates/yulgen/src/db.rs 50.00% <ø> (ø)
crates/yulgen/src/runtime/functions/abi.rs 100.00% <ø> (ø)
crates/driver/src/lib.rs 64.38% <53.33%> (-2.86%) ⬇️
crates/yulgen/src/mappers/module.rs 90.00% <90.00%> (ø)
crates/yulc/src/lib.rs 90.32% <100.00%> (+1.86%) ⬆️
crates/yulgen/src/db/queries.rs 100.00% <100.00%> (ø)
crates/yulgen/src/db/queries/contracts.rs 100.00% <100.00%> (ø)
crates/yulgen/src/lib.rs 100.00% <100.00%> (ø)
crates/yulgen/src/mappers/expressions.rs 90.79% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2097ec5...8dcf631. Read the comment docs.

@g-r-a-n-t g-r-a-n-t force-pushed the abi-specs branch 2 times, most recently from c75ac23 to 8dcf631 Compare March 22, 2022 03:34
@g-r-a-n-t
Copy link
Member Author

#887

@g-r-a-n-t g-r-a-n-t closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants