Allow public unsafe smart contract functions to be called from outside

[Narasimha1997]

What was wrong?

unsafe functions weren't allowed to be public (pub) as described in #687

How was it fixed?

The issue was fixed by removing the block of code that checked whether the function is both pub and unsafe. i.e by removing the following check.

Later, the tests were updated to respect the same by updating the snapshots using cargo insta review.

[codecov-commenter]

Codecov Report

Merging #695 (fc74ab6) into master (182d189) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
- Coverage   82.06%   82.05%   -0.01%     
==========================================
  Files         125      125              
  Lines       10881    10876       -5     
==========================================
- Hits         8929     8924       -5     
  Misses       1952     1952              

Impacted Files	Coverage Δ
crates/analyzer/src/db/queries/functions.rs	90.10% <ø> (-0.27%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182d189...fc74ab6. Read the comment docs.

[g-r-a-n-t]

looks good!

[g-r-a-n-t]

just need to run cargo fmt

[Narasimha1997]

@g-r-a-n-t , yup. Formatting issues are fixed in the latest commit.