-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
braces #707
braces #707
Conversation
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
+ Coverage 81.95% 82.20% +0.25%
==========================================
Files 125 125
Lines 10905 10876 -29
==========================================
+ Hits 8937 8941 +4
+ Misses 1968 1935 -33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just left a few nitpicks.
@@ -0,0 +1,28 @@ | |||
Braces! Fe has abandoned python-style significant whitespace in favor of the | |||
trusty curly brace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure trusty
is an intended word play :D
9c03c73
to
141c9e4
Compare
I'll merge this after #676 lands. |
<3 I am a big fan of curly bois |
Stage 1 of the pythonish -> rusty syntax transition.
else if
instead ofelif
pass
statementTo-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history