Allow traits to be implemented for almost all types #755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Currently traits can only be implemented for structs. The reason for that is that prior to monomorphization we do not know the
Location
of a type generic type (e.g.T
) and for that reason hard coded it toLocation::Memory
which would exclude primitive types such asu8
.How was it fixed?
I made attempts to get rid of
Location
in the analyzer entirely but I kept failing. Then I realized that we actually don't yet allow to assign generic arguments anyway. Since the location is only relevant for when variables are assigned we could have usedLocation::Value
and it would have worked exactly the same, it's superfluous information for now.Hence, I thought we could introduce a
Location::Unresolved
for now and in return lift the restriction to allow traits to be implemented for all base types, arrays and tuples.In addition this fixes two ICEs related to calling
to_mem()
orclone()
on a generic type.E.g.