Mut redux #777
Merged
Mut redux #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbillig
force-pushed
the
mut-redux
branch
2 times, most recently
from
0433251
to
2532bbf
Compare
sbillig
force-pushed
the
mut-redux
branch
2 times, most recently
from
e4c6af7
to
6c1694f
Compare
cburgdorf
approved these changes
Nov 18, 2022
| @@ -73,7 +73,7 @@ pub trait AnalyzerContext { | |||
| /// # Panics | |||
| /// | |||
| /// Panics if an entry does not already exist for the node id. | |||
| fn update_expression(&self, node: &Node<ast::Expr>, attributes: ExpressionAttributes); | |||
| fn update_expression(&self, node: &Node<ast::Expr>, f: &dyn Fn(&mut ExpressionAttributes)); | |||
There was a problem hiding this comment.
Nitpick: Imho single letter variables should be avoided at most times (except in some established math formulars etc). Maybe this could be fn.
| @@ -379,35 +384,6 @@ impl AnalyzerContext for TempContext { | |||
| } | |||
| } | |||
|
|
|||
| /// Indicates where an expression is stored. | |||
There was a problem hiding this comment.
It served us well but great to see it go now!
| @@ -123,12 +136,6 @@ pub fn function_signature( | |||
| arg.span, | |||
| "instances of `Context` must be named `ctx`", | |||
| ); | |||
| } else if !function.parent(db).is_contract() { | |||
There was a problem hiding this comment.
Curious why this was removed
There was a problem hiding this comment.
@cburgdorf This was a driveby change that should have been its own tiny PR; it's just an arbitrary restriction that shouldn't exist. There's no reason to prevent someone from writing a utility or library function that uses the context object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the concept of
mutability to the language. Anything not markedmutisn't mutable.The analyzer's
Type::Mutis mapped to MIR'sType::MPtrfor all non-primitive types. This works, but maybe isn't ideal. Perhapsmutparameters could be of typeMutRefor something, and mut vars wouldn't need a type wrapper at all in MIR. The ExpressionAttributes struct now contains a vec of "type adjustments", which are the implicit coercions that were performed to transform the expression into the expected type. This feels a bit fragile to me; perhaps better would be to introduce an HIR form, in which fe's implicit coercions would be "desugared" into explicit type coercions.Much of this PR feels like it could be better with more work, but I've reworked this enough times and let it stagnate for way too long, and I'm satisfied that this is at least an improvement over the current
mutless status.Subsumes #768; the rebasing required to keep that separate became a pain.
To-Do
Followup issues:
#810
#811
#812
#814