Implement trait associated functions #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/feat/trait_ass_fn
branch
from
1414c64
to
1e3c46d
Compare
cburgdorf
force-pushed
the
christoph/feat/trait_ass_fn
branch
4 times, most recently
from
49c2972
to
7206089
Compare
cburgdorf
changed the title
cburgdorf
commented
Nov 21, 2022
| @@ -1,7 +1,7 @@ | |||
| use crate::display::Displayable; | |||
| use crate::errors::{FatalError, IndexingError}; | |||
| use crate::namespace::items::{FunctionId, FunctionSigId, ImplId, Item, StructId, TypeDef}; | |||
| use crate::namespace::scopes::BlockScopeType; | |||
| use crate::namespace::scopes::{check_visibility, BlockScopeType}; | |||
There was a problem hiding this comment.
Should this be moved on the AnaylzerContext instead of importing it here?
Y-Nak
reviewed
Nov 21, 2022
Comment on lines
+6
to
+15
| error: Applicable items exist but are not in scope | ||
| ┌─ compile_errors/trait_not_in_scope2/src/foo.fe:11:6 | ||
| │ | ||
| 11 │ fn do() { | ||
| │ ^^ candidate #1 is defined here on trait `DoThing` | ||
| · | ||
| 16 │ fn do() { | ||
| │ ^^ candidate #2 is defined here on trait `DoOtherThing` | ||
| │ | ||
| = Hint: Bring one of these candidates in scope via `use module_name::trait_name` |
| @@ -995,8 +995,139 @@ fn expr_call_path<T: std::fmt::Display>( | |||
| generic_args: &Option<Node<Vec<fe::GenericArg>>>, | |||
| args: &Node<Vec<Node<fe::CallArg>>>, | |||
| ) -> Result<(ExpressionAttributes, CallType), FatalError> { | |||
| let named_thing = context.resolve_path(path, func.span)?; | |||
| expr_call_named_thing(context, named_thing, func, generic_args, args) | |||
| match context.resolve_any_path(path) { | |||
There was a problem hiding this comment.
Why is resolve_any_path called instead of resolve_visible_path? If a "normal" associated function is not visible, it should not be counted as a callable candidate.
For example, there is no ambiguity in the following example, but the compiler rejects it.
// a.fe
pub struct MyS {
fn x() -> u256 {
return 10
}
}
// main.fe
use a::MyS
trait Trait {
fn x() -> u256;
}
impl Trait for MyS {
fn x() -> u256 {
return 10
}
}
fn main() -> u256 {
return MyS::x()
}There was a problem hiding this comment.
Good catch! Eagle eyes! 🦅 I pushed a solution in another commit. I'm not super happy with it but I'm not very creative this morning.
cburgdorf
force-pushed
the
christoph/feat/trait_ass_fn
branch
from
7206089
to
fd226a7
Compare
Y-Nak
reviewed
Nov 22, 2022
| } | ||
| }; | ||
|
|
||
| if x.is_err() {} |
cburgdorf
force-pushed
the
christoph/feat/trait_ass_fn
branch
from
fd226a7
to
029e423
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We don't have trait associated functions.
How was it fixed?
Basically just enhanced
expr_call_pathto keep looking for candidates that are implemented via traits if we can not resolve the path directly on the type.This also includes #815 which can be reviewed seperately.