Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm test for new parser #841

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Add wasm test for new parser #841

merged 1 commit into from
Feb 5, 2023

Conversation

Y-Nak
Copy link
Member

@Y-Nak Y-Nak commented Feb 3, 2023 •
edited
Loading

  • Add wasm test
  • Use dir-test crate and remove the internal proc macro.

@Y-Nak Y-Nak marked this pull request as ready for review February 5, 2023 15:58
@Y-Nak Y-Nak requested a review from sbillig February 5, 2023 15:59
sbillig
sbillig approved these changes Feb 5, 2023
View reviewed changes
Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 That's a mighty fine macro you got there.

@sbillig sbillig merged commit 854ea48 into ethereum:fe-v2 Feb 5, 2023
@Y-Nak Y-Nak deleted the wasm-test branch February 5, 2023 21:33
Y-Nak added a commit that referenced this pull request Feb 6, 2023
@Y-Nak
Add wasm test for new parser (#841)
20c2af8
Y-Nak added a commit that referenced this pull request Feb 6, 2023
@Y-Nak
Add wasm test for new parser (#841)
eabdca4
Y-Nak added a commit that referenced this pull request Feb 6, 2023
@Y-Nak
Add wasm test for new parser (#841)
82fee03
Y-Nak added a commit to Y-Nak/fe that referenced this pull request Apr 20, 2023
@Y-Nak
Add wasm test for new parser (ethereum#841)
58f3dff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillig sbillig sbillig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Y-Nak @sbillig