Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::abi #856

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

std::abi #856

wants to merge 4 commits into from

Conversation

g-r-a-n-t
Copy link
Member

What was wrong?

How was it fixed?

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@g-r-a-n-t g-r-a-n-t marked this pull request as draft March 7, 2023 23:32
@Y-Nak
Copy link
Member

Y-Nak commented Mar 7, 2023

Just a question: Is this PR targeting the current fe implementation? I thought you would work on the std for fe-v2 after testing implementation.

@g-r-a-n-t
Copy link
Member Author

Just a question: Is this PR targeting the current fe implementation? I thought you would work on the std for fe-v2 after testing implementation.

this is some non-committal sketch code, ultimately Im targeting v2. is the v2 branch stable enough to work on?

@Y-Nak
Copy link
Member

Y-Nak commented Mar 8, 2023 •
edited
Loading

I don't know how stable it should be for you to start working on it. At least the new parser will work. For semantics, I wouldn't add projection stuff, so basically, it's the same except for trait solving, type inference, and pointer types.

As I said, some std implementations are necessary to implement v2, like encode/decode stuff. So, It'd be better for me if you start targeting v2 implementation. But it's up to you.

@g-r-a-n-t g-r-a-n-t force-pushed the std-abi branch 2 times, most recently from c1284ea to 2a77608 Compare March 8, 2023 13:28
g-r-a-n-t
g-r-a-n-t commented Jun 28, 2023
View reviewed changes
crates/library/std/src/buf.fe
@@ -297,3 +297,48 @@ pub struct RawCallBuffer {
return self.buf.writer()
}
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this

@g-r-a-n-t g-r-a-n-t mentioned this pull request Jun 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cburgdorf cburgdorf cburgdorf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-r-a-n-t @Y-Nak @cburgdorf