Christoph/feat/gen structs #906
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@g-r-a-n-t I revived an old branch where I once started hacking together support for generic structs. I've looked into it again and I'm stuck with a certain problem. I'll leave another note inline. |
cburgdorf
commented
Jul 18, 2023
| // This seems to be the place were we could capture the mapping of generic types to concrete types. | ||
| // But how exactly is still unclear because we can not simply map TypeID to a fixed set of concrete types | ||
| // because the TypeID of `Foo<T>` is the same no matter if we deal with `Foo<u256>` or `Foo<bool>`. | ||
|
|
There was a problem hiding this comment.
That's basically what I'm currently stuck at. I'm not yet sure how to properly resolve generic structs in MIR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
How was it fixed?
To-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history