v2: modest parser improvements #934
Conversation
sbillig
force-pushed
the
parser-tweaks
branch
from
d1b4f35
to
baa2663
Compare
sbillig
force-pushed
the
parser-tweaks
branch
from
baa2663
to
dc853d4
Compare
|
@Y-Nak I'm inclined to merge these few simple changes as-is. I'm currently experimenting with the |
|
By "as-is" I don't mean that I won't make requested changes, of course, just that I'll do further parser restructuring separately. |
crates/parser2/src/parser/item.rs
Outdated
| loop { | ||
| match parser.current_kind() { | ||
| Some(kind) if kind.is_modifier_head() => { | ||
| if allow_modifier { | ||
| let (_, modifier_checkpoint) = | ||
| parser.parse(ItemModifierScope::default(), None); | ||
| checkpoint.get_or_insert(modifier_checkpoint); | ||
| } else { | ||
| parser | ||
| .unexpected_token_error("modifier is not allowed in this block", None); | ||
| } | ||
| } | ||
| _ => break, |
There was a problem hiding this comment.
This loop will introduce a false negative when a modifier is duplicated. e.g.,
pub pub fn foo()
crates/parser2/src/parser/mod.rs
Outdated
| /// Proceeds the parser to the recovery token of the current scope. | ||
| pub fn recover(&mut self) { | ||
| /// Consumes tokens until a recovery token is found, and reports an error on any | ||
| /// unexpexted tokens. |
There was a problem hiding this comment.
| /// unexpexted tokens. | |
| /// unexpected tokens. |
typo
|
I left two nits. I feel it'd be better to continue the discussion on #972. Please feel free to merge the PR after the nits are resolved. |
sbillig
force-pushed
the
parser-tweaks
branch
from
2aef062
to
277ad77
Compare
|
@Y-Nak I decided to apply one more change to this PR. Previously, |
sbillig
force-pushed
the
parser-tweaks
branch
from
277ad77
to
32f801f
Compare
sbillig
force-pushed
the
parser-tweaks
branch
from
32f801f
to
36aaf9a
Compare
{)... ?