Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: Allow mut occurrence only in path pattern #990

Merged
merged 1 commit into from
Feb 28, 2024
Merged

parser: Allow mut occurrence only in path pattern #990

merged 1 commit into from
Feb 28, 2024

Conversation

Y-Nak
Copy link
Member

@Y-Nak Y-Nak commented Feb 28, 2024

This PR restricts

  1. the mut keyword occurrence in a pattern only before Path,
  2. Add a field to Hir::Pat::Path to indicate the mutability of the path.

The main reason for the change was that I hesitated to make all HIR pattern kinds include mutability flags.

@Y-Nak Y-Nak requested a review from sbillig February 28, 2024 21:04
sbillig
sbillig approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbillig sbillig merged commit 65f3804 into ethereum:fe-v2 Feb 28, 2024
7 checks passed
@Y-Nak Y-Nak deleted the restrict-mut-in-pattern branch February 29, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillig sbillig sbillig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Y-Nak @sbillig