Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect instantiation in constraint solving #998

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

Y-Nak
Copy link
Member

@Y-Nak Y-Nak commented Apr 24, 2024

I broke the constraint solver when I introduced Binder.
This PR also adds the Callable information in the type checker, which will be necessary for MIR-lowering and the WF check for types that are implicitly introduced in method resolution.

@Y-Nak Y-Nak requested a review from sbillig April 24, 2024 16:15
Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbillig sbillig merged commit 2fca91c into ethereum:fe-v2 Apr 25, 2024
7 checks passed
@Y-Nak Y-Nak deleted the fix-constraints-solver branch April 25, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants