les: use nicer constants

les/api.go

@@ -20,6 +20,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"math"
 	"sync"
 	"time"
 
@@ -38,7 +39,7 @@ var (
 	errNoPriority           = errors.New("not enough priority")
 )
 
-const maxBalance = 9000000000000000000
+const maxBalance = math.MaxInt64
 
 type clientApiFields struct {
 	balanceUpdatePeriod uint64
@@ -154,12 +155,12 @@ func (api *PrivateLightServerAPI) setParams(params map[string]interface{}, clien
 loop:
 	for name, value := range params {
 		errValue := func() error {
-			return errors.New(fmt.Sprintf("invalid value for parameter '%s'", name))
+			return fmt.Errorf("invalid value for parameter '%s'", name)
 		}
 		setFactor := func(v *float64) {
 			if posFactors != nil {
 				if val, ok := value.(float64); ok && val >= 0 {
-					*v = val / 1000000000
+					*v = val / float64(time.Second)
 					updateFactors = true
 				} else {
 					err = errValue()
@@ -186,7 +187,7 @@ loop:
 		default:
 			processed = false
 			if defParams {
-				err = errors.New(fmt.Sprintf("invalid default parameter '%s'", name))
+				err = fmt.Errorf("invalid default parameter '%s'", name)
 				continue loop
 			}
 		}
@@ -226,7 +227,7 @@ loop:
 				err = errClientNotConnected
 			}
 		default:
-			err = errors.New(fmt.Sprintf("invalid client parameter '%s'", name))
+			err = fmt.Errorf("invalid client parameter '%s'", name)
 		}
 	}
 	return updateFactors, err

les/clientpool.go

@@ -622,7 +622,7 @@ func (f *clientPool) getPosBalance(id enode.ID) *posBalance {
 	return balance
 }
 
-// getPosBalanceIDs returns a lexicographically ordered list of IDs of accounts
+// getPosBalanceIDs returns a lexicographically ordered list of IDs from accounts
 // with a positive balance
 func (f *clientPool) getPosBalanceIDs(start, stop enode.ID, maxCount int) (result []enode.ID) {
 	if maxCount <= 0 {

les/clientpool_test.go

@@ -104,7 +104,7 @@ func testClientPool(t *testing.T, connLimit, clientCount, paidCount int, randomD
 
 		if tickCounter == testClientPoolTicks/4 {
 			// give a positive balance to some of the peers
-			amount := int64(testClientPoolTicks / 2 * 1000000000) // enough for half of the simulation period
+			amount := testClientPoolTicks / 2 * int64(time.Second) // enough for half of the simulation period
 			for i := 0; i < paidCount; i++ {
 				pool.forClients([]enode.ID{poolTestPeer(i).ID()}, func(client *clientInfo, id enode.ID) {
 					pool.updateBalance(id, amount, true, "")