core, miner: avoid miscaching while getting sender from tx #14773
Conversation
markya0616
force-pushed
the
cache_from
branch
2 times, most recently
from
0628250
to
3b6a4aa
Compare
|
Could you detail a bit what the exact issue was, the scenario where it came up and why this fix solves it? I don't quite understand what you're trying to fix here. |
|
In our team, we are trying to set up a private blockchain environment to evaluate the system performance. We found |
markya0616
force-pushed
the
cache_from
branch
2 times, most recently
from
3ca65fb
to
2568646
Compare
|
@karalabe Do you have any other comments for this PR? |
core/types/transaction.go
Outdated
| func (t *TransactionsByPriceAndNonce) Shift() { | ||
| signer := deriveSigner(t.heads[0].data.V) | ||
| // derive signer but don't cache. | ||
| func (t *TransactionsByPriceAndNonce) Shift(signer Signer) { |
There was a problem hiding this comment.
I pinged @karalabe in a voice call and he doesn't like this change because calling Shift with some signer other than EIP155 can derive a different sender address and mess up the tx set. A suggestion: maybe we should store the signer to use on the TransactionsByPriceAndNonce struct.
There was a problem hiding this comment.
@fjl Thanks for the feedback. I updated my commit to store the signer in TransactionsByPriceAndNonce and check the sender address before we construct it. Please help review. Thanks!
|
@karalabe ping |
|
@karalabe Do you have other suggestion for this PR? |
The tx sender is usually mis-cached because of different signer if we are running a new chain. Get the correct signer to get sender cache.