les: wg data race fixed #15365
les: wg data race fixed #15365
Conversation
JekaMas
force-pushed
the
syncLoop-race
branch
from
bfdbcff
to
853d5d3
Compare
|
Thanks for catching it! There is a better way to fix this though. wg.Add should not happen inside the goroutine but before starting it. Then it is guaranteed that it runs in the init phase, before starting the entire LightEthereum backend and the additional semaphore is not needed at all. |
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
JekaMas
force-pushed
the
syncLoop-race
branch
from
98b63fb
to
b85aca6
Compare
|
@zsfelfoldi Thanks for advice! I've make requested changes. |
JekaMas
force-pushed
the
syncLoop-race
branch
from
b85aca6
to
a231fdb
Compare
les/handler.go
Outdated
| @@ -242,7 +243,7 @@ func (pm *ProtocolManager) Stop() { | |||
| // will exit when they try to register. | |||
| pm.peers.Close() | |||
|
|
|||
| // Wait for any process action | |||
| // Wait for any process action. Wait should be executed after all pm.wg.Add() | |||
There was a problem hiding this comment.
Thanks. This and upper changes has been done.
les/handler.go
Outdated
| @@ -115,6 +115,7 @@ type ProtocolManager struct { | |||
|
|
|||
| // channels for fetcher, syncer, txsyncLoop | |||
| newPeerCh chan *peer | |||
| isClosed *int32 | |||
There was a problem hiding this comment.
This is left over from your previous change, please remove.
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
JekaMas
force-pushed
the
syncLoop-race
branch
from
596c13b
to
b04eb83
Compare
Fixes #15364