Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/rlpdump: allow hex input to have leading '0x' #15389

Merged
merged 1 commit into from
Oct 27, 2017
Merged

cmd/rlpdump: allow hex input to have leading '0x' #15389

merged 1 commit into from
Oct 27, 2017

Conversation

mcdee
Copy link
Contributor

@mcdee mcdee commented Oct 27, 2017

rlpdump fails with a hex input prefixed with 0x, for example:

$ rlpdump --hex 0x00
encoding/hex: invalid byte: U+0078 'x'

This patch allows hex strings to be prefixed with '0x':

$ rlpdump --hex 0x00
00

Existing functionality is unchanged.

@karalabe karalabe added this to the 1.7.3 milestone Oct 27, 2017
@karalabe karalabe merged commit 6dafec0 into ethereum:master Oct 27, 2017
@5chdn 5chdn mentioned this pull request Nov 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdee @fjl @karalabe