Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth: Fix #3483 #15762

Closed
wants to merge 1 commit into from
Closed

eth: Fix #3483 #15762

wants to merge 1 commit into from

Conversation

shbli
Copy link

@shbli shbli commented Dec 27, 2017 •
edited
Loading

eth: Fix #3483

@shbli shbli requested a review from karalabe as a code owner December 27, 2017 14:07
@shbli
Copy link
Author

shbli commented Dec 28, 2017

@karalabe This is my first PR into the etherium go project 👍 I am interested to continually contribute but I want to get a feel of the approval process and what if anything is accepted or not.

Let me know if the solution here is good enough, or require some refactoring.

holiman
holiman approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (aside from goimports formatting error)

@holiman holiman mentioned this pull request Dec 20, 2018
Merged
@holiman
Copy link
Contributor

holiman commented Dec 20, 2018

Superseded by #18346

@holiman holiman closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

Assignees

@holiman holiman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shbli @holiman