build: fix version comparison for Go 1.10+ #15781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
approved these changes
Jan 2, 2018
dm4
pushed a commit
to second-state/lityvm
that referenced
this pull request
Apr 25, 2018
jyap808
referenced
this pull request
Apr 30, 2018
We have decided to bump the requirement to Go 1.7 because it enables subtests and allows dropping backwards-compatibility code. This is in line with Go's support policy. Go 1.6 and earlier no longer receive security updates.
dm4
pushed a commit
to second-state/lityvm
that referenced
this pull request
May 9, 2018
Salokyn
pushed a commit
to banquedefrance/go-ethereum
that referenced
this pull request
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug that appears when users upgrade to Go 1.10. Our version comparison in the make scripts use textual comparison to check if we have at least Go 1.7 available. However,
"Go1.10"is less than"Go1.7", somakerefuses building with Go 1.10.The PR changes the logic so that instead of textual comparison, we try to parse the minor version number and numerically compare against
7.