Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whisper/whisper2: fix Go 1.10 vet issues on type mismatches #15783

Merged
merged 1 commit into from
Jan 2, 2018

Conversation

karalabe
Copy link
Member

There are two fmt.Sprintf type errors in whisper, where the requested formatting type is hex %x, but the input is a whisper.Envelope. This PR fixes it by actually printing what the dev intended (the hash on the envelope).

Btw, the fmt.Sprintf is useless in the log (was an automatic refactor), but since whisper2 is deprecated already, this PR is just meant to fix the type issue (which results in a compilation error on Go 1.10), but doesn't attempt to further clean up the old code.

@fjl fjl merged commit b98aa3b into ethereum:master Jan 2, 2018
tsuzukit pushed a commit to tsuzukit/quorum that referenced this pull request May 25, 2018
tsuzukit added a commit to tsuzukit/quorum that referenced this pull request May 29, 2018
tsuzukit added a commit to tsuzukit/quorum that referenced this pull request May 29, 2018
jpmsam pushed a commit to Consensys/quorum that referenced this pull request Jun 4, 2018
* same fix as ethereum/go-ethereum#15783
* Fix insufficient balance for transfer
* change chainId of QuorumTestChainConfig
Szkered pushed a commit to Szkered/quorum that referenced this pull request Jun 14, 2018
* same fix as ethereum/go-ethereum#15783
* Fix insufficient balance for transfer
* change chainId of QuorumTestChainConfig
Szkered pushed a commit to Szkered/quorum that referenced this pull request Jun 22, 2018
* same fix as ethereum/go-ethereum#15783
* Fix insufficient balance for transfer
* change chainId of QuorumTestChainConfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants