eth/api_tracer.go: enable preimage recording when tracing #15787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
approved these changes
Jan 2, 2018
|
Felix, are you even reviewing or just merging? The error is capitalized.
…On Jan 2, 2018 13:49, "Felix Lange" ***@***.***> wrote:
Merged #15787 <#15787>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#15787 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAH6GTQxKS5hhDyD3T2yk0gMqv12UVl1ks5tGhfAgaJpZM4RQMdc>
.
|
fjl
added a commit
to fjl/go-ethereum
that referenced
this pull request
Jan 3, 2018
This reverts commits 85a1eda (ethereum#15792) and c495bca (ethereum#15787) because they introduce database writes during tracing.
fjl
added a commit
that referenced
this pull request
Jan 3, 2018
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
This reverts commits 85a1eda (ethereum#15792) and c495bca (ethereum#15787) because they introduce database writes during tracing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables preimage recording (#3543) when tracing a tx with
debug_traceTransaction. Recorded preimages will then be available through requests todebug_preimage.This is useful if the user the user doesn't want to re-sync from the genesis block with
--vmdebug, and is only interested in preimages around specific transactions.