cmd/utils/flags.go: Applying a String len guard for the gitCommit param of the NewApp() #15790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
epappas
changed the title
…am of the NewApp()
epappas
force-pushed
the
fix/string-len-guard
branch
from
f3d7750 to
89be5f7
Compare
epappas
changed the title
karalabe
reviewed
Jan 3, 2018
cmd/utils/flags.go
Outdated
| @@ -96,7 +96,7 @@ func NewApp(gitCommit, usage string) *cli.App { | |||
| //app.Authors = nil | |||
| app.Email = "" | |||
| app.Version = params.Version | |||
| if gitCommit != "" { | |||
| if gitCommit != "" && len(gitCommit) >= 8 { | |||
There was a problem hiding this comment.
You can drop the gitCommit != "" part, len(gitCommit) >= 8 already validates that it's not "".
cooganb
referenced
this pull request
in cooganb/go-ethereum
Jan 23, 2018
…#15790) * cmd/utils/flags.go: Applying a String len guard for the gitCommit param of the NewApp() * cmd/utils: remove redundant clause in if condition
cooganb
referenced
this pull request
in cooganb/go-ethereum
Feb 23, 2018
…#15790) * cmd/utils/flags.go: Applying a String len guard for the gitCommit param of the NewApp() * cmd/utils: remove redundant clause in if condition
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
…thereum#15790) * cmd/utils/flags.go: Applying a String len guard for the gitCommit param of the NewApp() * cmd/utils: remove redundant clause in if condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple guard to match the check-case of [1]. Seems that for some applications, people are trying to sneak in the git-tag (version) of theirs, rather than an actual commit hash. This is only to protect them.
[1] https://github.com/ethereum/go-ethereum/blob/master/params/version.go#L41