Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethclient: add DialContext and Close #16318

Merged
merged 3 commits into from
Apr 19, 2018
Merged

ethclient: add DialContext and Close #16318

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbabb84
ethclient: add DialContext function
asymmetric Mar 14, 2018
ea4ced5
ethclient: implement Dial in terms of DialContext
asymmetric Mar 14, 2018
cbe882a
ethclient: add Close method
asymmetric Mar 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ethclient/ethclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ type Client struct {

// Dial connects a client to the given URL.
func Dial(rawurl string) (*Client, error) {
c, err := rpc.Dial(rawurl)
return DialContext(context.Background(), rawurl)
}

func DialContext(ctx context.Context, rawurl string) (*Client, error) {
c, err := rpc.DialContext(ctx, rawurl)
if err != nil {
return nil, err
}
Expand All @@ -51,6 +55,10 @@ func NewClient(c *rpc.Client) *Client {
return &Client{c}
}

func (ec *Client) Close() {
ec.c.Close()
}

// Blockchain Access

// BlockByHash returns the given full block.
Expand Down