Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Ensure that local transactions aren't discarded as underpriced #16576

Merged
merged 1 commit into from
May 2, 2018
Merged

core: Ensure that local transactions aren't discarded as underpriced #16576

merged 1 commit into from
May 2, 2018
+14 −10

Conversation

trailtacos
Copy link
Contributor

This fixes an issue where local transactions are discarded as
underpriced when the pool and queue are full.

vogelito
vogelito approved these changes Apr 26, 2018
View reviewed changes
Copy link

@vogelito vogelito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’re having issues with our own transactions being discarded. This is a fix for that.

@karalabe
Copy link
Member

Nice catch!

@karalabe karalabe added this to the 1.8.7 milestone Apr 27, 2018
@trailtacos trailtacos mentioned this pull request Apr 27, 2018
Closed
@karalabe
core: ensure local transactions aren't discarded as underpriced
0afd767 
This fixes an issue where local transactions are discarded as
underpriced when the pool and queue are full.
karalabe
karalabe approved these changes May 2, 2018
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've expanded the test a bit.

@karalabe karalabe merged commit 579ac62 into ethereum:master May 2, 2018
@trailtacos trailtacos deleted the bugfix/local_underpriced_txs branch May 2, 2018 15:31
@vogelito vogelito mentioned this pull request May 11, 2018
Closed
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request May 9, 2024
@gzliudan
core: Ensure that local transactions aren't discarded as underpriced (e…
2060ff7 
…thereum#16576)
@gzliudan gzliudan mentioned this pull request May 17, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogelito vogelito vogelito approved these changes

@karalabe karalabe karalabe approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.7
Development

Successfully merging this pull request may close these issues.
3 participants
@trailtacos @karalabe @vogelito