Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts/*: golint updates for this or self warning #16619

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

kielbarry
Copy link
Contributor

In the contracts directory, I have updated the variable names for receivers generating a golint warning regarding use of generic names like this or self.

contracts/ens/ens.go Outdated Show resolved Hide resolved
@GitCop
Copy link

GitCop commented May 2, 2018

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 64ed58a3a7ccd6a37ddd25c0d857a095a7772238
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

contracts/ens/ens.go Outdated Show resolved Hide resolved
contracts/ens/ens.go Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented May 4, 2018

As I got the situation we have to finalise block , on betting base. Deltafork I saw offered suitable sample. Sorry, I am really newcomer

@ghost
Copy link

ghost commented May 4, 2018

I need to discuss the technical matters, the other side it us clear to issue the signal for crowdsale and voting via Eth Ecosystem. Pls any comment if is right

@GitCop
Copy link

GitCop commented May 7, 2018

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 64ed58a3a7ccd6a37ddd25c0d857a095a7772238

  • Commits must be prefixed with the package(s) they modify

  • Commit: 1bcc642259ecce0e4660d404f29bdc48f057308a

  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented May 7, 2018

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 64ed58a3a7ccd6a37ddd25c0d857a095a7772238

  • Commits must be prefixed with the package(s) they modify

  • Commit: 1bcc642259ecce0e4660d404f29bdc48f057308a

  • Commits must be prefixed with the package(s) they modify

  • Commit: 25f893be4449495ae0e8cb61ea58cf122e9a7c5b

  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

1 similar comment
@GitCop
Copy link

GitCop commented May 15, 2018

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 64ed58a3a7ccd6a37ddd25c0d857a095a7772238

  • Commits must be prefixed with the package(s) they modify

  • Commit: 1bcc642259ecce0e4660d404f29bdc48f057308a

  • Commits must be prefixed with the package(s) they modify

  • Commit: 25f893be4449495ae0e8cb61ea58cf122e9a7c5b

  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

@kielbarry
Copy link
Contributor Author

@karalabe apologies for this being stale. I've made the changes you requested and am passing the CI/CD build - please let me know if there are additional steps I need to take.

@karalabe karalabe self-assigned this Feb 7, 2019
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge on green

@karalabe karalabe merged commit 85b3b1c into ethereum:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants