-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contracts/*: golint updates for this or self warning #16619
Conversation
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
As I got the situation we have to finalise block , on betting base. Deltafork I saw offered suitable sample. Sorry, I am really newcomer |
I need to discuss the technical matters, the other side it us clear to issue the signal for crowdsale and voting via Eth Ecosystem. Pls any comment if is right |
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
1 similar comment
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
@karalabe apologies for this being stale. I've made the changes you requested and am passing the CI/CD build - please let me know if there are additional steps I need to take. |
65f82bd
to
49bbe59
Compare
49bbe59
to
159e991
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge on green
In the contracts directory, I have updated the variable names for receivers generating a golint warning regarding use of generic names like this or self.