all: change TxPreEvent to TxsPreEvent #16720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
holiman,
karalabe and
zsfelfoldi
as code owners
rjl493456442
changed the title
holiman
approved these changes
May 18, 2018
core/tx_journal.go
Outdated
| for _, err := range errs { | ||
| // Create a method to load a limited batch of transactions and bump the | ||
| // appropriate progress counters. Then use this method to load all the | ||
| // journelled transactions in small-ish batches. |
rjl493456442
commented
May 18, 2018
core/tx_pool.go
Outdated
| @@ -653,7 +653,7 @@ func (pool *TxPool) add(tx *types.Transaction, local bool) (bool, error) { | |||
| log.Trace("Pooled new executable transaction", "hash", hash, "from", from, "to", tx.To()) | |||
|
|
|||
| // We've directly injected a replacement transaction, notify subsystems | |||
| go pool.txFeed.Send(TxsPreEvent{types.Transactions{tx}}) | |||
| go pool.txFeed.Send(NewTxsEvent{types.Transactions{tx}}) | |||
There was a problem hiding this comment.
Will it be better if we post the NewTxsEvent synchronously here?
There was a problem hiding this comment.
Felix started looking into the synchronous postings, so I'd rather keep that can of worms in a separate pr.
quocneo
referenced
this pull request
in haloplatform/go-haloplatform
Jul 19, 2018
…lay, Raft minter with NewTxsEvent
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 28, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a transaction is promoted, a
TxPreEventwill be pushed to subscribers immediately.While when the number of new transactions received is large, there are too many
TxPreEventwill be pushed leads totxFeedlock resource contention.So in this PR, i replace all
TxPreEventtoTxsPreEvent. So that we can push a batch of new promoted txs together. It will help in these scenario：Besides, in this PR, also fix a small problem.
When we apply new promoted transaction to mining block, it should sill abide original gas limit restriction instead of creating a new gas limit.