Prevent usage of invalid command or bootnodes #17248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the daemon thing? Geth can work fine with just argument flags, it doesn't need a subcommand. |
|
ah yes. in that case, it can be reduced to Here is the check: Since |
|
Very nice, now I understand what this PR is for :) I really wanted to have this for a long time, thank you for solving it this elegantly. |
firmianavan
pushed a commit
to firmianavan/go-ethereum
that referenced
this pull request
Aug 28, 2018
* cmd: stop parsing bootnodes if one is invalid * cmd/geth: require valid command as argument (or no arg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two fatal startup errors, to prevent unintended behavior due to invalid flag usage.