Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: implement Constantinople EIP 1234 #17657

Closed
wants to merge 1 commit into from
Closed

consensus: implement Constantinople EIP 1234 #17657

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 12, 2018

@ghost ghost requested a review from karalabe as a code owner September 12, 2018 10:49
@holiman
Copy link
Contributor

holiman commented Sep 12, 2018

Thanks! Instead of copy-pasting the diff calc, with a change of constant, might be nicer to have a factory create both calcdifficultyXX-methods in init. So you call it like:
calcDifficultyConstantinople = createDiffCalc(big49999)

@ghost
Copy link
Author

ghost commented Sep 12, 2018

@holiman Yes and you should refactor the code starting from func CalcDifficulty which will be very dirty with eip100 part 😄

@holiman holiman mentioned this pull request Sep 15, 2018
@karalabe
Copy link
Member

Closing in favor of #17675

@karalabe karalabe closed this Sep 17, 2018
@ghost ghost deleted the eip1234 branch September 17, 2018 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants