Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-1186 eth_getProof #17737

Merged
merged 8 commits into from
Oct 18, 2018
Merged

EIP-1186 eth_getProof #17737

merged 8 commits into from
Oct 18, 2018

Conversation

simon-jentzsch
Copy link
Contributor

Implementation of the EIP-1186, which adds a rpc-endpoint eth_getProof

@simon-jentzsch simon-jentzsch mentioned this pull request Sep 22, 2018
Closed
2 tasks
@simon-jentzsch simon-jentzsch changed the title In3 EIP-1186 eth_getProof Sep 22, 2018
@fjl fjl self-requested a review September 28, 2018 20:35
holiman
holiman reviewed Oct 18, 2018
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
core/state/statedb.go Outdated Show resolved Hide resolved
internal/ethapi/api.go Show resolved Hide resolved
internal/ethapi/api.go Outdated Show resolved Hide resolved
internal/ethapi/api.go Outdated Show resolved Hide resolved
holiman
holiman reviewed Oct 18, 2018
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
core/state/statedb.go Outdated Show resolved Hide resolved
core/state/statedb.go Outdated Show resolved Hide resolved
holiman
holiman approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks left, but otherwise LGTM

core/vm/interface.go Outdated Show resolved Hide resolved
common/bytes.go Show resolved Hide resolved
@simon-jentzsch
Copy link
Contributor Author

simon-jentzsch commented Oct 18, 2018 •
edited
Loading

thanks for taking the time to review the code!

@simon-jentzsch simon-jentzsch mentioned this pull request Oct 18, 2018
Merged
@holiman holiman merged commit 97fb083 into ethereum:master Oct 18, 2018
@holiman holiman added this to the 1.8.18 milestone Oct 18, 2018
@fjl fjl mentioned this pull request Oct 23, 2018
Merged
@ryanschneider ryanschneider mentioned this pull request Nov 7, 2018
Merged
@nivida nivida mentioned this pull request Nov 20, 2019
Closed
@gzliudan gzliudan mentioned this pull request Nov 22, 2022
Open
@holiman holiman mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligi ligi ligi approved these changes

@holiman holiman holiman approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@fjl fjl Awaiting requested review from fjl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.18
Development

Successfully merging this pull request may close these issues.
3 participants
@simon-jentzsch @ligi @holiman