Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/debug: support color terminal for cygwin/msys2 #17740

Merged
merged 3 commits into from
Sep 29, 2018

Conversation

hackmod
Copy link
Contributor

@hackmod hackmod commented Sep 22, 2018

fixed color terminal support for cygwin/msys2

  • update go-colorable, go-isatty, go-runewidth packages
  • use go-isatty instead of log/term and remove log/term package

fixed default data path issue under cygwin/msys2

  • use APPDATA env variable for windows

node/defaults.go Outdated Show resolved Hide resolved
@fjl fjl changed the title support color terminal for cygwin/msys2 internal/debug: support color terminal for cygwin/msys2 Sep 28, 2018
@fjl
Copy link
Contributor

fjl commented Sep 28, 2018

Please remove the change in package node for now. We can make it in a separate PR.

@fjl fjl merged commit 44eb695 into ethereum:master Sep 29, 2018
@mksully22
Copy link

can you provide some insight on why building for ppc64 and ppc64le was disabled for vendor/github.com/mattn/go-isatty/isatty_linux.go module?

@hackmod
Copy link
Contributor Author

hackmod commented Jan 1, 2019

@mksully22 oops! some files are missing!

gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 13, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 14, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 14, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 14, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 15, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 15, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants