-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/puppeth: implement chainspec converters #18172
Conversation
c56d5d2
to
371b3e2
Compare
|
Todo, fix up |
@holiman Can you add support for single server deploy with multiple nodes & services? For example deploying bootnodes, ethstats, & explorer at a one instance. Also I would like to know is it possible to support clique engine on parity since they are adding them soon |
@naikmyeong I thought single-server deploy was already suppprted? File a ticket otherwise. It won't be part of this PR. Re Clique, sure, good idea. Do you have a reference chainspec to base it off? |
The The PR was merged in https://github.com/goerli/parity-goerli instead, and bugs fixed in this revision. Assume most up-to-date version will also be in that repo. EDIT: I'm not sure how "stable" this is to be considered. |
converter
from Geth to Parity/Aleth chain specs
bb977ae
to
02dcbb5
Compare
Not to the format per se, but |
Oh, what we should do is not add a specific trinity config, but instead an |
02dcbb5
to
fc9a012
Compare
rebased to get rid of test fails, and formatted to get rid of linting errors |
fc9a012
to
8698fba
Compare
I've reworked the converters so they are part of the wizard. I know it may be a bit more annoying than having a shortcut cli tool, but it's important for me that puppeth behaves uniformly independent of what operation it's expected of it. I've also added support to import existing (geth/native) genesis specs from a file, or http(s) urls (i.e. I can directly pull the Rinkeby genesis from its website). Export wise it reads a destination folder now and pushes into @holiman PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the current code, if @holiman agrees with my followup changes, we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from a minor nitpick. Not allowed to approve the PR though, since I'm the author
d416401
to
d4415f5
Compare
converter
from Geth to Parity/Aleth chain specs
This PR updates puppeth with the most recent changes to the parity and aleth chain specifications. It also adds a feature to convert from a geth genesis to a parity chainspec.
It also contains a testcase which compares the generated stureby chainspecs with the 'official' stureby chainspecs, according to https://gist.github.com/5chdn/baf0eb40cbaff5a90befc52815d6950b.
I did not touch
harmony
, which currently uses the exact same format asgeth
. @mkalinin, is that correct?Also,
pyethereum
is deprecated, @pipermerriam have trinity now implemented chainspecs?Example output
The
stureby.json
file is this one. Resulting parity spec:And for
aleth
: