Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/utils: max out the OS file allowance, don't cap to 2K #18211

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Nov 29, 2018

Supersedes #17597, as it can achieve the same results without any flags (i.e. automagically), whilst also ensuring we don't accidentally go over any OS limits (panic in leveldb).

Fast sync benchmarks, 4096 cache, i3.2xlarge (post sync):

The curious thing here is that memory usage seems to be a lot lower and more stable, which is an interesting find. Why would more file descriptors cause less memory? Perhaps there's some issue in leveldb which leaks memory, at least temporarily? Idea: perhaps it's the transaction pool, not the database!

screenshot from 2018-12-04 13-27-42

Full sync bnchmarks, 2084 cache, i3.2xlarge:

The speed seems to be more or less the same (4h difference over the course of 4 days, might as well just be a slightly different machine). Database IO wise the "infinite" file descriptors do seem to result in a a 6-7% lower rate. Probably nothing spectacular.

screenshot from 2018-12-07 14-05-16


All in all benchmarks point that there's nothing spectacular happening with this PR, at least on the Linux VMs. I think it's safe to merge just to get rid of an artificial limit we had in our code until now.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but we should probably try it out on the benchmarking nodes. Although, we could also just merge it to master as soon as possble to get maximum testing on various platforms before next release

@karalabe
Copy link
Member Author

Would be interesting to see the speed effect. Lets leave the leveldb 128MB thing running for a day and if the results are conclusive we can replace that benchmark with this one.

@karalabe karalabe merged commit d2328b6 into ethereum:master Dec 7, 2018
jyap808 added a commit to ubiq/go-ubiq that referenced this pull request Feb 4, 2019
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 11, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 17, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 18, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 26, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 29, 2024
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 3, 2024
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 19, 2024
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants