fix #18254, Need to throw error when methods are called at future… #18422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaods
force-pushed
the
fix-18254
branch
6 times, most recently
from
612c675
to
603cd6a
Compare
xiaods
changed the title
xiaods
force-pushed
the
fix-18254
branch
3 times, most recently
from
7b05932
to
56d8b68
Compare
|
@karalabe do you have some advice on it? |
…ture blocks -[x] add unit test for StorageAt rpc call -[x] Return error message on future block -[x] add TransactionCount rpc call unit testing Signed-off-by: Deshi Xiao <xiaods@gmail.com>
|
The new ethclient tests in this PR don't really work. I made them work in #18346. Closing this PR because we will merge the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18254 , Need to throw error when methods are called at future…
Signed-off-by: Deshi Xiao xiaods@gmail.com