Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p/discover: improve table addition code #18974

Merged
merged 2 commits into from
Jan 31, 2019

Commits on Jan 30, 2019

  1. p2p/discover: improve table addition code

    This change clears up confusion around the two ways in which nodes
    can be added to the table.
    
    When a neighbors packet is received as a reply to findnode, the nodes
    contained in the reply are added as 'seen' entries if sufficient space
    is available.
    
    When a ping is received and the endpoint verification has taken place,
    the remote node is added as a 'verified' entry or moved to the front of
    the bucket if present. This also updates the node's IP address and port
    if they have changed.
    fjl committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    1f36fd3 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2019

  1. p2p/discover: fix comments

    Co-Authored-By: fjl <fjl@users.noreply.github.com>
    holiman and fjl authored Jan 31, 2019
    Configuration menu
    Copy the full SHA
    5e8e208 View commit details
    Browse the repository at this point in the history