Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add audit reports #18996

Merged
merged 2 commits into from
Feb 6, 2019
Merged

docs: add audit reports #18996

merged 2 commits into from
Feb 6, 2019

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Feb 5, 2019

This PR contains two audits made on the go-ethereum codebase, one on geth in general and one focused on Clef

@karalabe
Copy link
Member

karalabe commented Feb 5, 2019

Nitpick, could we order them by date? (i.e. rename) Might be more meaningful long term if we do more audits.

@karalabe
Copy link
Member

karalabe commented Feb 5, 2019

Also, does it make sense to have "Report", "Ethereum Foundation", "EF", and "v1.0" in the file names?

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe added this to the 1.9.0 milestone Feb 6, 2019
@karalabe karalabe merged commit 75c9570 into ethereum:master Feb 6, 2019
t4n6a1ka added a commit to t4n6a1ka/go-ethereum that referenced this pull request Jul 2, 2019
Copy link

@immense055 immense055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/audits/Truesec_Report_Geth_2017-04-25.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants