core: fix import errors on clique crashes + empty blocks #19862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this addresses clique non-archive node re-syncing state after a non-graceful shutdown: ethereum#19838 code is borrowed from: ethereum#19544
|
Thanks for the PR, but we consider the 1.8 release family frozen. Unless there's some high risk security issue that would warrant an immediate hotfix release in the near future, no more code will be merged on that branch. Back-porting code always entails a risk of breaking something, and we'd rather have 1.8 locked in at the current stability level (with whatever quirks), than potentially causing a breaking issue for anyone on it. As we develop on master, we only regularly test that branch. Additionally, only ever supporting the latest stable release ensures we don't spend time debugging issues that have been fixed a long time ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this addresses clique non-archive node re-syncing state after a
non-graceful shutdown: #19838
code is borrowed from: #19544