-
Notifications
You must be signed in to change notification settings - Fork 20.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
les: separate peer into clientPeer and serverPeer #19991
Conversation
6d9ab88
to
03feffd
Compare
@zsfelfoldi I think this big stuff is ready for review. If you have the plan to review something, please take a look. |
03feffd
to
3e29395
Compare
3e29395
to
f0f6dd3
Compare
f0f6dd3
to
a8e3f2f
Compare
a8e3f2f
to
8ac452f
Compare
8ac452f
to
843af02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of it is nice, the only serious issue is the blocking send in broadcastHeaders
. Also, splitting peerSet
too would be nice (unless it would cause some serious trouble elsewhere which I am not aware of).
843af02
to
15d3b0a
Compare
@zsfelfoldi Fixed, ptal again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* les: separate peer into clientPeer and serverPeer * les: address comments
* internal/ethapi: default to zero address for calls (ethereum#20702) This makes eth_call and eth_estimateGas use the zero address as sender when the "from" parameter is not supplied. Co-authored-by: Felix Lange <fjl@twurst.com> * les: separate peer into clientPeer and serverPeer (ethereum#19991) * les: separate peer into clientPeer and serverPeer * les: address comments * mobile: add CallOpts.SetFrom (ethereum#20721) This was missing because I forgot to wrap it when bind.CallOpts.From as added. * crypto/bn256: fix import line (ethereum#20723) * p2p/discv5: fix test on go 1.14 (ethereum#20724) Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: gary rong <garyrong0905@gmail.com> Co-authored-by: Adam Schmideg <adamschmideg@users.noreply.github.com>
* les: separate peer into clientPeer and serverPeer * les: address comments
* les: separate peer into clientPeer and serverPeer * les: address comments
This is the second big refactor PR for les package.
In this PR, peers are separated into two types: serverPeer and clientPeer. The former refers to the peers of
light_client
. The latter refers to the peers ofles_server
.