cmd, core, eth, les: support --override.istanbul #20004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am adding this flag to my k8s stateful set as a backup (commented out) in case it needs to be updated quickly. Would this be the correct way to use this feature? # if the istanbul hardfork gets delayed, uncomment this
# to buy time until approximately January 6th, 2020
# - --override.istanbul
# - 9250000Should there be an issue, uncomment this setting, and redeploy to rewind a few blocks and continue for four more weeks...if it goes well, delete this commented out section and continue as normal. I wasn't able to find an official block height for January 6th, but I assume this would be good enough until more information was released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clone of #18273 to support overriding the Istanbul fork block until it passes.