Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: make unit tests work with Go 1.13 #20053

Merged
merged 7 commits into from
Sep 11, 2019
Merged

all: make unit tests work with Go 1.13 #20053

merged 7 commits into from
Sep 11, 2019

Commits on Sep 11, 2019

  1. cmd/geth: make attach tests more reliable 

    This makes the test wait for the endpoint to come up by polling
it instead of waiting for two seconds.
    @fjl
    fjl committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    b4c771f View commit details
    Browse the repository at this point in the history

  2. tests: fix test binary flags for Go 1.13 

    Calling flag.Parse during package initialization is prohibited
as of Go 1.13 and causes test failures. Call it in TestMain instead.
    @fjl
    fjl committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    a7cb0c5 View commit details
    Browse the repository at this point in the history

  3. crypto/ecies: remove useless -dump flag in tests

    @fjl
    fjl committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    5b60f14 View commit details
    Browse the repository at this point in the history

  4. p2p/simulations: fix test binary flags for Go 1.13 

    Calling flag.Parse during package initialization is prohibited
as of Go 1.13 and causes test failures. Call it in TestMain instead.
    @fjl
    fjl committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    b6e6731 View commit details
    Browse the repository at this point in the history

  5. build: remove workaround for ./... vendor matching 

    This workaround was necessary for Go 1.8. The Go 1.9 release changed
the expansion rules to exclude vendored packages.
    @fjl
    fjl committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    de9ba1b View commit details
    Browse the repository at this point in the history

  6. Makefile: use relative path for GOBIN 

    This makes the "Run ./build/bin/..." line look nicer.
    @fjl
    fjl committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    fa92e42 View commit details
    Browse the repository at this point in the history

  7. les: fix test binary flags for Go 1.13 

    Calling flag.Parse during package initialization is prohibited
as of Go 1.13 and causes test failures. Call it in TestMain instead.
    @fjl
    fjl committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    fd1b87e View commit details
    Browse the repository at this point in the history