eth: eth/64 - extend handshake with with fork id #20140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Oct 1, 2019
|
|
hadv
reviewed
Oct 5, 2019
karalabe
force-pushed
the
eth64-handshake-forkid
branch
2 times, most recently
from
2ce5f3a
to
9e542de
Compare
karalabe
force-pushed
the
eth64-handshake-forkid
branch
from
9e542de
to
64571f9
Compare
karalabe
changed the title
fjl
approved these changes
Oct 30, 2019
19 tasks
wanwiset25
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jun 19, 2024
wanwiset25
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jun 28, 2024
wanwiset25
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 23, 2024
)" This reverts commit ae52ca6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
ethprotocol's handshake with afork idfield as defined in https://eips.ethereum.org/EIPS/eip-2124, and bumps the version number toeth/64(oldeth/63is supported side by side of course).The fork ID was designed to help split the network in case some nodes upgrade and some don't, but both chains progress (typical for test nets during hard forks). With this code in place, Ropsten would now (Istanbul forking) be able to cleanly split itself between updated nodes and non-updated ones.