Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/utils: fix command line flag resolve #20167

Merged
merged 1 commit into from
Oct 15, 2019
Merged

cmd/utils: fix command line flag resolve #20167

merged 1 commit into from
Oct 15, 2019

Commits on Oct 15, 2019

  1. cmd/utils: fix command line flag resolve 

    In Geth, we have two sources for configuration:
(1) Config file
(2) Command line flag

Basically geth will first resolve config file and then overwrite
configs with command line flags.

This issue is: geth should only overwrite configs if flags are truly
set. So before we apply any flag to configs, `GlobalIsSet` check
is necessary.
    @rjl493456442
    rjl493456442 committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    67b9988 View commit details
    Browse the repository at this point in the history