core/vm: fast push/pop/swap/dup #21193
Closed
+794
−121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
This PR breaks consensus theoretically, because if there's a push outside the range of the code, we just push a zero on the stack. In practice, that's fine, because execution will stop at that point anyway.
There's something odd happening. I'm not getting any test failures, but
The gas used is funky. I think it may be because the
bench
flag makes the execution reuse the same state, and does not reset it between runs. So if the bench is invoked several times, it can report different values.Some synthetic benchmarks: