consensus/ethash: less lookups of block data #21467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -204,11 +204,20 @@ func (ethash *Ethash) VerifyUncles(chain consensus.ChainReader, block *types.Blo | |||
|
|
|||
| number, parent := block.NumberU64()-1, block.ParentHash() | |||
| for i := 0; i < 7; i++ { | |||
| ancestorHeader := chain.GetHeader(parent, number) | |||
| if ancestorHeader == nil { | |||
There was a problem hiding this comment.
Just one concern, if we lose the header because the database reason, we may loosen rules for checking block.
There was a problem hiding this comment.
Yes, I know. It might be worth having a panic here, but I didn't want to introduce one now -- since the current code just silently does the exact same thing
rjl493456442
approved these changes
Aug 21, 2020
holiman
force-pushed
the
minor_ethashfix
branch
from
defd914
to
493100b
Compare
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a small optimization picked from #19456
When verifying a block PoW, we need to check an ancestor's uncles. However, most blocks don't have uncles, and in those cases we can avoid loading the full block, and just make do with the header.