Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/geth: remove copydb command #22501

Merged
merged 2 commits into from
Mar 15, 2021
Merged

cmd/geth: remove copydb command #22501

merged 2 commits into from
Mar 15, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Mar 15, 2021

Removes the geth copydb command. It's pretty broken,

There were two errors that had borked it:

  1. The pruning makes it likely to fail, since it serves the head block, but the client tries to sync at head-64. However, we usually do have head-127, so as long as we pretend that head-127+64 is the latest block, things works smoothly.
  2. The fast-sync-server implementation in fakePeer hadn't been rewritten to handle separation of code and state.

Also, with the new offline pruner, there's not much point in fixing up copydb.

@holiman
Copy link
Contributor Author

holiman commented Mar 15, 2021

Closes #19266

@karalabe
Copy link
Member

Can you also nuke downloader.FakePeer?

@holiman
Copy link
Contributor Author

holiman commented Mar 15, 2021

Aye, done!

@karalabe karalabe added this to the 1.10.2 milestone Mar 15, 2021
karalabe
karalabe approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe merged commit faacc8e into ethereum:master Mar 15, 2021
AusIV pushed a commit to NoteGio/go-ethereum that referenced this pull request Jul 12, 2021
@holiman @meowsbits
cmd/geth, eth/downloader: remove copydb command (ethereum#22501)
834b492 
* cmd/geth: remove copydb command

* eth/downloader: remove fakepeer

 Conflicts:
	cmd/geth/chaincmd.go
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@holiman @atif-konasl
cmd/geth, eth/downloader: remove copydb command (ethereum#22501)
4e24ee1 
* cmd/geth: remove copydb command

* eth/downloader: remove fakepeer
@quorumbot quorumbot mentioned this pull request Apr 28, 2022
Merged
9 tasks
formingform added a commit to formingform/PlatON-Go that referenced this pull request Apr 20, 2023
@formingform
refactor: cmd/platon: remove copydb command
4082eea 
ethereum/go-ethereum#22501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@holiman @karalabe