core/state: remove unused methods ReturnGas, GetStorageProofByHash #23092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
changed the title
s1na
reviewed
Jun 23, 2021
| @@ -333,17 +333,6 @@ func (s *StateDB) GetStorageProof(a common.Address, key common.Hash) ([][]byte, | |||
| return proof, err | |||
| } | |||
|
|
|||
| // GetStorageProofByHash returns the Merkle proof for given storage slot. | |||
| func (s *StateDB) GetStorageProofByHash(a common.Address, key common.Hash) ([][]byte, error) { | |||
There was a problem hiding this comment.
This function seems to have been added here: 017831d#diff-c3757dc9e9d868f63bc84a0cc67159c1d5c22cc5d8c9468757098f0492e0658cR340
Not sure about the context or use
There was a problem hiding this comment.
yeah, I have searched the go-ethereum project,
no context found to use it
fjl
changed the title
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…thereum#23092) Co-authored-by: lidongwei <lidongwei@huobi.com>
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.