Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth/tracers: support for golang tracers + add golang callTracer #23708
eth/tracers: support for golang tracers + add golang callTracer #23708
Changes from all commits
af67e1d
57c993b
c9c1dc9
340c773
bf165bb
4ea0d15
75c6aff
7b10534
ca5427a
d9371f3
aff90d3
a2b0d3d
18c4c17
0946623
5db19c5
360e3ba
c55a903
a9c2051
c242c82
60f5734
89bac76
91a7c09
2a69a37
4e2de46
de953f5
2af565b
a839259
01bb908
2de2d6c
a9b91d7
8a5d5f0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, apparently this is not covered by the tests, think you can add a test that flags this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required for this PR though