Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts/abi/bind: refactor transact method #23719

Merged
merged 5 commits into from
Oct 13, 2021
Merged

accounts/abi/bind: refactor transact method #23719

merged 5 commits into from
Oct 13, 2021
+217 −81

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Oct 12, 2021 •
edited by fjl
Loading

This PR refactors the transact method making it easier to read and easier to reason about.
This however results in ~ 40 lines more compared to the original method.
I would still argue that it's a valid refactor as it clearly discriminates between Dynamic and Legacy transactions.

It fixes an issue where executing a transaction would overwrite the transactOpts, and adds a test for it.
Previously the gasEstimation would populate the feeCap/tipCap fields which would mean that if a second transaction would be send with the same transactionOpts, the gas estimation would not be executed anymore.

It also changes the code s.th. transact only queries the blockchain if gasPrice is not specified.
If gasPrice is set, we just construct a legacy transaction. If not we query the head if basefee is already set.

supersedes #23663
supersedes #23587
closes #23586

fjl
fjl reviewed Oct 12, 2021
View reviewed changes
accounts/abi/bind/base.go Outdated Show resolved Hide resolved
@fjl fjl changed the title accounts/abi/bind: Refactor transact method accounts/abi/bind: refactor transact method Oct 12, 2021
@fjl fjl added this to the 1.10.10 milestone Oct 12, 2021
@fjl fjl merged commit 79b727b into ethereum:master Oct 13, 2021
This was referenced Oct 13, 2021
Closed
Closed
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 14, 2021
@MariusVanDerWijden @yondonfu @fjl
accounts/abi/bind: refactor transact method (ethereum#23719)
20267b7 
This fixes a bug where gas-related fields of the TransactOpts passed
to transaction methods would be modified, skipping gas estimation for
subsequent transactions.

Co-authored-by: Yondon Fu <yondon.fu@gmail.com>
Co-authored-by: Felix Lange <fjl@twurst.com>
tynes added a commit to ethereum-optimism/optimism that referenced this pull request Oct 19, 2021
@tynes
gas-oracle: bump go-ethereum dep to v1.10.10
336d6d8 
Bumps the go-ethereum dep to release v1.10.10
which fixes a bug with the transact opts where
it is mutated and can cause gas estimation errors.

See ethereum/go-ethereum#23719
@tynes tynes mentioned this pull request Oct 19, 2021
Merged
smartcontracts pushed a commit to ethereum-optimism/optimism that referenced this pull request Nov 10, 2021
@tynes @smartcontracts
gas-oracle: bump go-ethereum dep to v1.10.10
8ed6131 
Bumps the go-ethereum dep to release v1.10.10
which fixes a bug with the transact opts where
it is mutated and can cause gas estimation errors.

See ethereum/go-ethereum#23719
@MariusVanDerWijden MariusVanDerWijden deleted the refactor-transact branch November 30, 2021 15:28
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@MariusVanDerWijden @yondonfu
@fjl @zzyalbert
accounts/abi/bind: refactor transact method (ethereum#23719)
c76d7ea 
This fixes a bug where gas-related fields of the TransactOpts passed
to transaction methods would be modified, skipping gas estimation for
subsequent transactions.

Co-authored-by: Yondon Fu <yondon.fu@gmail.com>
Co-authored-by: Felix Lange <fjl@twurst.com>
@gzliudan gzliudan mentioned this pull request May 30, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
f48faf0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
8b76467
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
7122de3
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
c774fe1
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
fc9a260
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 10, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
22a8cc9
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
5e280d7
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
4c86811
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
7ae46ff
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
834a949
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
4d99965
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
7b16e9d
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
69eb2dc
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
c289235
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
2f7409e
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
6e90eaf
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
72c8ad9
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
7e3ae26
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
72abd7a
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
d566e38
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
9ea09cd
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
b2c727f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
594bbcb
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
5ea00db
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
31a8057
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
0414c11
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
3b5203e
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
0b965dc
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
@gzliudan
accounts/abi/bind: refactor transact method (ethereum#23719)
eec8da3
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Nov 13, 2024
@gzliudan @wanwiset25
accounts/abi/bind: refactor transact method (ethereum#23719)
82b4566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl left review comments

@gballet gballet Awaiting requested review from gballet gballet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.10
Development

Successfully merging this pull request may close these issues.

Remove unnecessary calls to eth_getBlockByNumber when gasPrice is set
3 participants
@MariusVanDerWijden @fjl @yondonfu