Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsre: downgrade web3.js due to issues with printing BigNumbers #2445

Closed
wants to merge 1 commit into from

Conversation

bas-vk
Copy link
Member

@bas-vk bas-vk commented Apr 12, 2016

This PR downlogrades web3.js to the previous version. The latest version gives problems with printing BigNumbers and I need @frozeman helps to determine the actual problem. The latest version of web3.js comes with the personal extensions which where removed on upgrade. These are restored.

@robotally
Copy link

Vote Count Reviewers
👍 0
👎 0

Updated: Tue Apr 12 15:43:31 UTC 2016

@fjl
Copy link
Contributor

fjl commented Apr 12, 2016

We can also fix the printer instead.

@bas-vk
Copy link
Member Author

bas-vk commented Apr 12, 2016

I'm not really sure what the problem is. The printer seems fine to me.

@fjl
Copy link
Contributor

fjl commented Apr 12, 2016

This check is broken.

@fjl
Copy link
Contributor

fjl commented Apr 12, 2016

See #2448

@bas-vk bas-vk closed this Apr 12, 2016
@obscuren obscuren removed the review label Apr 12, 2016
@bas-vk bas-vk deleted the web3-downgrade branch April 16, 2016 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants