Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rlp: support for uint256 #26898

Merged
merged 17 commits into from
Mar 17, 2023
Merged

rlp: support for uint256 #26898

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4c5c9b5
rlp: support for uint256
holiman Mar 15, 2023
eb8c057
rlp: return error for too large uint256
fjl Mar 15, 2023
56c659e
rlp: fix decoding of non-pointer uint256
fjl Mar 15, 2023
0d92715
rlp: add uint256 tests
fjl Mar 15, 2023
08d450e
rlp: handle encoding u256 both pointer and non-pointer
holiman Mar 16, 2023
5084e85
rlp: implement encoderlp for uint256.Int
holiman Mar 16, 2023
4712879
rlp: benchmark tests for u256
holiman Mar 16, 2023
6f9fcc4
rlp: add EncoderBuffer method for Uint256
fjl Mar 16, 2023
c5306d3
rlp: update comment
fjl Mar 16, 2023
87b7fdb
Update rlp/encbuffer.go
holiman Mar 16, 2023
b774ecc
rlp: rename to ReadUint256
fjl Mar 16, 2023
6e9d483
rlp/rlpgen: add support for uint256
fjl Mar 16, 2023
0a2fdfb
rlp: add failing test for array encoding
fjl Mar 16, 2023
89298f7
rlp: fix array test
fjl Mar 16, 2023
8a6cbf8
rlp: check for uint256 more strictly
fjl Mar 16, 2023
aa376f8
rlp: check for uint256 more strictly in decoder
fjl Mar 16, 2023
4ad1faa
rlp/rlpgen: update uint256 output after renaming of method
holiman Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions rlp/encode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"reflect"

"github.com/ethereum/go-ethereum/rlp/internal/rlpstruct"
"github.com/holiman/uint256"
)

var (
Expand Down Expand Up @@ -144,6 +145,10 @@ func makeWriter(typ reflect.Type, ts rlpstruct.Tags) (writer, error) {
return writeBigIntPtr, nil
case typ.AssignableTo(bigInt):
return writeBigIntNoPtr, nil
case typ.AssignableTo(reflect.PtrTo(u256Int)):
return writeU256IntPtr, nil
case typ.AssignableTo(u256Int):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a problem with this check. As written, this will also trigger for values of type [4]uint64, because those values are also 'assignable' to uint256.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Ouch

Copy link
Contributor

@fjl fjl Mar 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We check for big.Int in the same way, but it's less of a problem because (1) big.Int is a struct with private fields, and (2) it is usually handled as a pointer, and named types can't be pointers (type X *big.Int is not allowed by compiler).

return writeU256IntNoPtr, nil
case kind == reflect.Ptr:
return makePtrWriter(typ, ts)
case reflect.PtrTo(typ).Implements(encoderInterface):
Expand Down Expand Up @@ -206,6 +211,22 @@ func writeBigIntNoPtr(val reflect.Value, w *encBuffer) error {
return nil
}

func writeU256IntPtr(val reflect.Value, w *encBuffer) error {
ptr := val.Interface().(*uint256.Int)
if ptr == nil {
w.str = append(w.str, 0x80)
return nil
}
ptr.EncodeRLP(w)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird. We shouldn't rely on the method in uint256 here. Instead, we can just put the encoding logic in this package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed, please check

return nil
}

func writeU256IntNoPtr(val reflect.Value, w *encBuffer) error {
i := val.Interface().(uint256.Int)
i.EncodeRLP(w)
return nil
}

func writeBytes(val reflect.Value, w *encBuffer) error {
w.writeBytes(val.Bytes())
return nil
Expand Down
7 changes: 3 additions & 4 deletions rlp/encode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,9 @@ var encTests = []encTest{
val: new(uint256.Int).SetBytes(unhex("0100020003000400050006000700080009000A000B000C000D000E01")),
output: "9C0100020003000400050006000700080009000A000B000C000D000E01",
},
// non-pointer uint256.Int -- not supported
// encode_test.go:402: test 47: unexpected error: rlp: unadressable value of type uint256.Int, EncodeRLP is pointer method
//{val: *uint256.NewInt(0), output: "80"},
//{val: *uint256.NewInt(0xFFFFFF), output: "83FFFFFF"},
// non-pointer uint256.Int
{val: *uint256.NewInt(0), output: "80"},
{val: *uint256.NewInt(0xFFFFFF), output: "83FFFFFF"},

// byte arrays
{val: [0]byte{}, output: "80"},
Expand Down