Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rlp: support for uint256 #26898

Merged
merged 17 commits into from
Mar 17, 2023
+316 −2
Merged

rlp: support for uint256 #26898

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4c5c9b5
rlp: support for uint256
holiman Mar 15, 2023
eb8c057
rlp: return error for too large uint256
fjl Mar 15, 2023
56c659e
rlp: fix decoding of non-pointer uint256
fjl Mar 15, 2023
0d92715
rlp: add uint256 tests
fjl Mar 15, 2023
08d450e
rlp: handle encoding u256 both pointer and non-pointer
holiman Mar 16, 2023
5084e85
rlp: implement encoderlp for uint256.Int
holiman Mar 16, 2023
4712879
rlp: benchmark tests for u256
holiman Mar 16, 2023
6f9fcc4
rlp: add EncoderBuffer method for Uint256
fjl Mar 16, 2023
c5306d3
rlp: update comment
fjl Mar 16, 2023
87b7fdb
Update rlp/encbuffer.go
holiman Mar 16, 2023
b774ecc
rlp: rename to ReadUint256
fjl Mar 16, 2023
6e9d483
rlp/rlpgen: add support for uint256
fjl Mar 16, 2023
0a2fdfb
rlp: add failing test for array encoding
fjl Mar 16, 2023
89298f7
rlp: fix array test
fjl Mar 16, 2023
8a6cbf8
rlp: check for uint256 more strictly
fjl Mar 16, 2023
aa376f8
rlp: check for uint256 more strictly in decoder
fjl Mar 16, 2023
4ad1faa
rlp/rlpgen: update uint256 output after renaming of method
holiman Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rlp/encode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,10 @@ var encTests = []encTest{
output: "F90200CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376CF84617364668471776572847A786376",
},

// arrays
{val: [4]uint32{1, 2, 3, 4}, output: "8401020304"},
Copy link
Contributor Author

@holiman holiman Mar 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the want C401020304 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I made a mistake. It's fixed now though!

{val: [4]uint64{1, 2, 3, 4}, output: "8401020304"},

// RawValue
{val: RawValue(unhex("01")), output: "01"},
{val: RawValue(unhex("82FFFF")), output: "82FFFF"},
Expand Down